Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update CONTRIBUTING.md with Python 3.12 #1197

Merged
merged 3 commits into from
Oct 17, 2024

Conversation

raisadz
Copy link
Contributor

@raisadz raisadz commented Oct 17, 2024

Some doctests do not work for lower Python versions so setting the contributing guide to install Python 3.12.

What type of PR is this? (check all applicable)

  • πŸ’Ύ Refactor
  • ✨ Feature
  • πŸ› Bug Fix
  • πŸ”§ Optimization
  • πŸ“ Documentation
  • βœ… Test
  • 🐳 Other

Related issues

  • Related issue #
  • Closes #

Checklist

  • Code follows style guide (ruff)
  • Tests added
  • Documented the changes

If you have comments or can explain your changes, please do so below.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 17, 2024
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @raisadz !

@raisadz raisadz marked this pull request as ready for review October 17, 2024 10:07
@MarcoGorelli
Copy link
Member

CI failure is unrelated and due to #1198

@MarcoGorelli MarcoGorelli merged commit 58973a0 into main Oct 17, 2024
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants